[pygtk] upgrade woes: pygtk 1.99.17 to 2.7.3, GDK_IS_DRAWABLE (drawable)' failed

[george young]

On Mon, 22 Aug 2005 14:08:26 -0400
Jesse Pavel <jpavel at alum.mit.edu> threw this fish to the penguins:

> 
> george young on August 22, 2005 wrote:
>  > [x86 linux]
>  > I'm upgrading from:
>  >    python 2.3.3, pygtk-1.99.17, gtk+-2.2.4 
>  > to:
>  >    python 2.4.1, pygtk-2.7.3, gtk+-2.8.0
>  > 
>  > In addition to a number of deprecation warnings, which I'm working on,
>  > I get many instances of:
>  > 
>  >    er.py:6155): Gdk-CRITICAL **: gdk_drawable_get_colormap: assertion `GDK_IS_DRAWABLE (drawable)' failed
>  >    (er.py:6155): Gdk-WARNING **: gdk_window_set_back_pixmap(): pixmap must have a colormap
>  > 
>  > and some areas of the application that should be colored turn out black.
> 
> 
> There was a thread on this bug in one of the GTK+ development lists
> a short while ago, and Owen Taylor fixed the problem in the GTK+ 2.8.0
> sources that caused the black areas and assertion. Perhaps the fix
> is still in CVS--but I've deleted the original message so I'm not
> sure. Take a look through the GTK+ mailing list archives.

 Found it in CVS, thanks!  For the record, the patch is:

--- gdk/x11/gdkwindow-x11.c     12 Aug 2005 13:13:54 -0000      1.247
+++ gdk/x11/gdkwindow-x11.c     15 Aug 2005 12:34:49 -0000
@@ -2913,7 +2913,7 @@ gdk_window_set_back_pixmap (GdkWindow *w
   g_return_if_fail (pixmap == NULL || !parent_relative);
   g_return_if_fail (pixmap == NULL || gdk_drawable_get_depth (window) == gdk_drawable_get_depth (pixmap));

-  if (!gdk_drawable_get_colormap (pixmap))
+  if (pixmap && !gdk_drawable_get_colormap (pixmap))
     {
       g_warning ("gdk_window_set_back_pixmap(): pixmap must have a colormap");
       return;

-- George
-- 
"Are the gods not just?"  "Oh no, child.
What would become of us if they were?" (CSL)