[pygtk] pygobject/pygtk issues with PySignal_SetWakeupFd support code

Daniel Drake dsd at laptop.org
Mon Jan 12 02:10:48 WST 2009


Hi,

As described at http://bugzilla.gnome.org/show_bug.cgi?id=481569 there
are numerous problems with the code that uses PySignal_SetWakeupFd()
to avoid polling for signals, including a misuse of the GSource  API
and excessive CPU usage due to not emptying the pipe.

I've fixed it up to use GSourceFuncs appropriately which solves the
problem, my pygobject patch is here:
http://bugzilla.gnome.org/attachment.cgi?id=125878&action=view

Full bug report is here:
http://bugzilla.gnome.org/show_bug.cgi?id=481569

The patch has blessings from Adam Olsen, a python guru. It has been
tested in OLPCs development builds for the last few weeks.

Is it OK for me to commit it to pygobject trunk and pygobject-2.16,
and pygtk trunk and pygtk-2-14?

Thanks!
Daniel


More information about the pygtk mailing list