[pygtk] introspection pygobject branch

[Tomeu Vizoso]

On Tue, Oct 20, 2009 at 18:44, Johan Dahlin <johan at gnome.org> wrote:
> On Sun, Oct 18, 2009 at 9:23 AM, Tomeu Vizoso <tomeu at sugarlabs.org> wrote:
>> On Tue, Oct 13, 2009 at 18:40, Simon van der Linden
>> <svdlinden at src.gnome.org> wrote:
>>> On 13 Oct 2009, at 18:40, Colin Walters wrote:
>>>> Does anyone know the status of merging the Summer of Code branch for
>>>> improving the GObject Introspection support?
>>>
>>> Nothing has been merged yet. A bug has been opened:
>>> https://bugzilla.gnome.org/show_bug.cgi?id=597697
>>>
>>>> Is it blocked on patch review?
>>>
>>> Basically, yes; it needs a reviewer.
>>
>> Would like to see some movement here, Simon has done a great work and
>> I personally think that introspection support is very important for
>> the future of PyGTK.
>>
>> From my POV, the person most knowledgeable about introspection support
>> in PyGObject is Johan Dahlin, but he's probably too busy at Litl to
>> carry the review forward. I'm cc'ing him so he can express his opinion
>> if he wishes.
>>
>> The second in line would be me, who took Johan's work and pushed it
>> forward enough to run Sugar on top of it, see:
>>
>> http://blog.tomeuvizoso.net/2009/05/reducing-sugars-memory-usage.html
>>
>> Simon carried his GSoC project on top of my work adding lots of
>> missing stuff and cleaning up the code a lot.
>>
>> Also, I have a big interest in doing a good review because I'm going
>> to be working myself on this area in the near future, and hopefully
>> the next release of Sugar will depend heavily on it.
>>
>> So I propose that I review the part of the branch that affects
>> girepository and find someone else who reviews the small bits that
>> affect the rest of pygobject.
>
> I can help out reviewing the parts of pygobject. Is it a big patch?
> Where can I find it?

This is the diffstat for the non-introspection part of it:

[tomeu at zviratko pygobject-i]$ git diff --stat origin/master gobject/
 gobject/Makefile.am         |    9 +++
 gobject/gobjectmodule.c     |   80 +++++++++++++++++++++-
 gobject/pygboxed.c          |   71 ++++++++++++--------
 gobject/pyginterface.c      |    6 +-
 gobject/pygobject-private.h |    7 ++
 gobject/pygobject.c         |  114 ++++++++++++++++++++++++--------
 gobject/pygobject.h         |   22 ++++++
 gobject/pygpointer.c        |  157 +++++++++++++++++++++++++++++++++++++------
 gobject/pygtype.c           |   88 ++++++++++++++++++++----
 9 files changed, 461 insertions(+), 93 deletions(-)

Thanks,

Tomeu

-- 
«Sugar Labs is anyone who participates in improving and using Sugar.
What Sugar Labs does is determined by the participants.» - David
Farning